Skip to content

Conversation

apollo13
Copy link
Contributor

This publishes the job definition view in the newest nomad versions:
image

if err != nil {
return err
}
cr := fmt.Sprintf(`{"Job": %s, "Submission": {"Source": %s, "Format": "hcl2", "VariableFlags": {}, "Variables": ""}}`, string(jsonJob), string(hcl_str))

Check failure

Code scanning / CodeQL

Potentially unsafe quoting

If this [JSON value](1) contains a double quote, it could break out of the enclosing quotes.
@nicholasjackson
Copy link
Contributor

Apologies on the delay in getting this merged @apollo13, I have been snowed under with work the last couple of weeks. I really value the contribution and will get things merged this weekend.

@apollo13
Copy link
Contributor Author

apollo13 commented Sep 8, 2023

Hi Nicholas, no worries. I am running from a custom checkout anyways :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants