add pre / post completion 'hooks' #1581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-remove duplicate FZF_DEFAULT_OPTS reference -add completion specific section
-evaluate new FZF_COMPLETION_PRE/POST_CMDS env vars to facilitate any necessary, temporary, tuning of the environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your excellent project!
I hit an issue with terminal text corruption in the completion output when moving (up/down) through the initial completion. It appeared like the set that fzf was iterating through was 'one off' that displayed on the screen. This left some nasty artifacts and made it difficult to read what was currently selected.
This turned out to be due to zsh's builtin 'timing statistics' outputting on the first line. The sledgehammer disabling of that feature wasn't palatable and hence this PR which, as per the example added to the
README.mdallows me to tune the environment pre and post fzf execution.I duplicated what I only really needed for zsh, to the
completion.bashscript too ..the changes appear (TM) to do what I want them to do ..you are clearly in a better position to determine side-affects ..I've only been using fzf a day or so.Cheers.