Use the vim-specific shell instead of the environment variable #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shell option is set by default to $SHELL, so it should not matter for standard setup users. This will allow to use a specific shell for vim, without needing to change the $SHELL environment variable too
janlazo
reviewed
Dec 16, 2019
| @@ -367,7 +367,7 @@ try | |||
| if !has_key(dict, 'source') && !empty($FZF_DEFAULT_COMMAND) && !s:is_win | |||
| let temps.source = s:fzf_tempname() | |||
| call writefile(s:wrap_cmds(split($FZF_DEFAULT_COMMAND, "\n")), temps.source) | |||
| let dict.source = (empty($SHELL) ? &shell : $SHELL).' '.fzf#shellescape(temps.source) | |||
| let dict.source = &shell.' '.fzf#shellescape(temps.source) | |||
There was a problem hiding this comment.
&shell is set to sh so there's no user customization here. You could set/unset $SHELL instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to use a specific shell for vim, without needing to change the $SHELL environment variable too.
The shell option is set by default to $SHELL, so it should not matter for users with standard setup.