Conversation
While a diff is active we hide the cell's own toolbar so it doesn't overlap the diff. JupyterLab renders both the cell toolbar and the diff footer's toolbar as <jp-toolbar>, so the bare selector was also matching the footer and hiding the Accept/Reject buttons. Scope the lookup to toolbars not inside a .jp-cellfooter.
Collaborator
|
Thanks @Zsailer. Could we use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a cell diff is active, the extension hides the cell's own toolbar so it doesn't overlap the diff view. The lookup matched
jp-toolbaranywhere under the cell node — but the cell input footer renders its own<jp-toolbar>, so any toolbar mounted there (e.g. footer action buttons) got hidden along with the cell toolbar.Fix: scope the lookup to
<jp-toolbar>elements that aren't inside a.jp-cellfooter, via a small_cellToolbar()helper used by bothhideCellToolbarandshowCellToolbar.