Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🗺 Add
tectonic
support #1093base: main
Are you sure you want to change the base?
🗺 Add
tectonic
support #1093Changes from 5 commits
4d03d91
3537822
6c0f3cf
6c7340c
5fec6ca
0526099
2e4e699
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think let's remove the duplication here by moving this command to
myst-cli/src/build/pdf
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
The only thing regarding the duplicated functions is that I cannot import them from
myst-cli/src/build/pdf/utils.ts
tojtex/src/tex/export.ts
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking to move the whole file over, but I see that is a bit complex, and we probably want to do it for typst at the same time.
I am happy to come in after and do a quick refactor, I also want to talk to @fwkoch to get a sense check on moving those around.
Have you tested the functionality locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works on my local machine. Cloned the forked repo and followed your contribution guidelines for developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic - I will give it a go today or tomorrow and we can get this released early next week. Thanks again for your help in the PR, excited to try out tectonic and stop recommending 5gb downloads ... !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
My pleasure. Yes, it's still relatively unknown, but it's such a step forward for local LaTeX compiling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the duplication - it would be nice to eliminate... that would mean "creating the command" (currently in
jtex
) and "invoking the command" (currently inmyst-cli
) in one single place. Definitely a smaller refactor to move "creation" tomyst-cli
, but it could also be interesting if part of the scope ofjtex
was to know how to create and invoke all the various rendering engines. MyST could then just say "jtex, build me a pdf using this template" hmm...Anyway - the duplication here is relatively minor; I don't think we need to block this PR with a big refactor.