💦 building widget state #1382
Merged
💦 building widget state #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
stevejpurves
force-pushed
the
feat/build-widget-state
branch
from
5d28c85
to
31e93aa
Compare
stevejpurves
force-pushed
the
feat/build-widget-state
branch
from
31e93aa
to
6bf4414
Compare
🦋 Changeset detectedLatest commit: a051955 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fwkoch
approved these changes
Aug 27, 2024
| /** | ||
| * Write widget state to file in public folder | ||
| */ | ||
| export function transformWidgetsToFile( |
There was a problem hiding this comment.
Steve and I chatted about this - there is some duplication between this and the notebook outputs caching. These also follow a slightly different pattern than other on-disk caching that is saved to the /cache folder. Definitely potential to normalize and deduplicate code... but for now, I think this standalone function is fine.
stevejpurves
force-pushed
the
feat/build-widget-state
branch
from
703e940
to
5d28c85
Compare
rowanc1
reviewed
Sep 24, 2024
| @@ -254,7 +255,9 @@ export async function transformMdast( | |||
| frontmatter, | |||
| mdast, | |||
| references, | |||
| }; | |||
| widgets, | |||
| something: 'else', | |||
Co-authored-by: Franklin Koch <[email protected]>
rowanc1
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims:
Todo: