Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace npm-run-all by npm-run-all2 #1942

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Nov 18, 2024

The current version of npm-run-all block updating cross-spawn.

This leads to a security issue https://github.com/jupyter/nbgrader/security/dependabot/53.

looks like this package is not necessary, this PR removes it.

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/nbgrader/remove_npm-run-all

@brichet brichet force-pushed the remove_npm-run-all branch from 2cdf669 to 27bb4a6 Compare January 29, 2025 12:27
@brichet brichet changed the title Remove unused dependency to npm-run-all Replace npm-run-all by npm-run-all2 Jan 29, 2025
@brichet
Copy link
Contributor Author

brichet commented Jan 29, 2025

Looks like it is used in

"watch": "run-p watch:src watch:labextension",
with the run-p CLI.

This fork has updated the dependencies, the initial project doesn't seems to be maintained anymore.

@brichet brichet merged commit 845cbc6 into jupyter:main Jan 29, 2025
25 checks passed
@brichet brichet deleted the remove_npm-run-all branch January 29, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant