Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates
@jupyter/eslint-plugininto the Jupyter Notebook codebase.The plugin is being actively developed to catch common issues and enforce best practices across Jupyter frontend projects, including JupyterLab, Notebook, and extensions. An early version is now available on npm, and this PR enables us to start validating the Notebook codebase against these rules.
Code changes
eslint.config.mjsto include the@jupyter/eslint-plugin.These settings follow the recommended configuration for Jupyter extensions.
We may consider making
command-described-byandplugin-descriptionstricter (error) if we decide to enforce them strictly across the codebase.User-facing changes
None
Backwards-incompatible changes
None