Use progress from child spawner #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minrk Let me know your thoughts |
|
Note: duplicate of #21. This method would require Python 3.5, and then we'll have to update batchspawner requirements to 3.5 in most cases. I don't mind and it would solve some other problems, but others would rather us support 3.4 longer. |
|
Now batchspawner doesn't support python3.4, but should this require 3.5 too? That seems to be the main choice between this and #21. This could be modified to handle the case of no child spawner yet (probably rare but perhaps useful), and then to directly return the child spawner method instead of running through a new generator. But that's basically #21... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jupyterhub/kubespawner#272 for details