Skip to content

Shortcuts fix#134

Open
yutahhhh wants to merge 4 commits intojupyterlab-contrib:mainfrom
QubitCube65:feature/shortcuts-fixed
Open

Shortcuts fix#134
yutahhhh wants to merge 4 commits intojupyterlab-contrib:mainfrom
QubitCube65:feature/shortcuts-fixed

Conversation

@yutahhhh
Copy link
Copy Markdown

@yutahhhh yutahhhh commented Jan 25, 2026

Important

Since this PR touches shortcut handling, so I recommend merging it before the following PRs:

Summary

  • Switched chalkboard toggles from '[' / ']' to 'L' / 'P'
  • Help dialog is now rendered inside .reveal, making it visible in fullscreen mode
  • Help button automatically disappears after 5 seconds when opening the slideshow, if not toggled manually

Changes

rise\packages\application\src\plugins\rise.ts:

  • Added a global keyboard handler using
    'document.addEventListener('keydown', (event: KeyboardEvent) => { ... }, true)'
  • Updated the help dialog rendering to ensure fullscreen visibility
  • Adjusted the auto-hide timer for the help button to 5 seconds

rise\packages\lab\schema\plugin.json:

  • Updated the displayed chalkboard download shortcut from \ to D to match actual behavior
  • Changed chalkboard toggle shortcuts to L (chalkboard) and P (notes canvas)

Updated Help-Menu

5B5A3382-449F-4940-BA82-A833E48B86A0
7EEAEEBC-C23E-42EF-B444-8D174F364174

Testing

  • Start slideshow in Jupyter
  • Verify that the help button in the bottom-left corner disappears after 5 seconds
  • Open the help menu by clicking the help button or pressing ?
  • Verify that all listed shortcuts work as described

@github-actions
Copy link
Copy Markdown

Binder 👈 Launch a Binder on branch QubitCube65/rise/feature%2Fshortcuts-fixed

@yutahhhh yutahhhh changed the title Normalize slideshow keyboard shortcuts Shortcuts fix Feb 11, 2026
yutahhhh added a commit to QubitCube65/rise that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant