Skip to content

Add api_base to common model parameters - #1478

Merged
dlqqq merged 1 commit into
jupyterlab:mainfrom
jonahjung22:add_apibase
Sep 4, 2025
Merged

dlqqq merged 1 commit into
jupyterlab:mainfrom
jonahjung22:add_apibase

Conversation

@jonahjung22

@jonahjung22 jonahjung22 commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Description

Adds the api_base: str model parameter to the common/static set of model parameters shown in the dropdown menu.

Code changes

Added an "api_base" string schema to the parameter_schemas.py file.

User-facing changes

Allows users to set the base URL where LLM requests are sent through a proxy gateway.

Backwards-incompatible changes

@jonahjung22 jonahjung22 self-assigned this Sep 3, 2025
@jonahjung22
jonahjung22 requested a review from dlqqq September 3, 2025 21:18
@jonahjung22 jonahjung22 changed the title Add custim model parameter bug fix Add custom model parameter bug fix Sep 3, 2025
@jonahjung22 jonahjung22 added bug:confirmed Bugs that have been confirmed by maintainers enhancement New feature or request labels Sep 3, 2025
@dlqqq

dlqqq commented Sep 4, 2025

Copy link
Copy Markdown
Member

Rebasing onto main to include #1464.

@dlqqq

dlqqq commented Sep 4, 2025

Copy link
Copy Markdown
Member

This PR doesn't fix the issue it references. It's still not possible to add a custom model parameter because this error surfaces after saving:

Screenshot 2025-09-04 at 1 48 04 PM

However, it does add the API base URL field, so I'm still inclined to merge this PR.

@dlqqq dlqqq changed the title Add custom model parameter bug fix Add api_base to model parameter suggestions Sep 4, 2025
@dlqqq dlqqq changed the title Add api_base to model parameter suggestions Add api_base to common model parameters Sep 4, 2025

@dlqqq dlqqq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've edited the title & description to be accurate. Thank you!

@dlqqq
dlqqq merged commit ac448b3 into jupyterlab:main Sep 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug:confirmed Bugs that have been confirmed by maintainers enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants