Skip to content

Conversation

@Darshan808
Copy link
Member

Fixes #483

This PR updates TempFileYStore so it can be used via command-line configuration.

The class now:

  • Inherits from LoggingConfigurable. (Config argument now gets passed here).
  • Uses a combined metaclass just like SQLiteYStore

With this change, TempFileYStore behaves consistently like SQLiteYStore when selected from the CLI.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch Darshan808/jupyter-collaboration/fix-TempFileYStore-implementation

@Darshan808 Darshan808 added the bug Something isn't working label Nov 28, 2025
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only sane way to test this is to run ui-tests with a separate startup script to pass configuration like we do for timeline

https://github.com/jupyterlab/jupyter-collaboration/blob/main/ui-tests/playwright.config.js
https://github.com/jupyterlab/jupyter-collaboration/blob/main/ui-tests/playwright.timeline.config.js

- name: run tests
working-directory: ui-tests
run: |
jlpm test
TIMELINE_FEATURE=1 jlpm test:timeline

(without the need to skip tests conditionally, but just running one test that would fail before this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when using a different YStore.

3 participants