Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open external links in system browser #883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Open external links in system browser #883

wants to merge 1 commit into from

Conversation

ozpau
Copy link

@ozpau ozpau commented Jan 17, 2025

This solves #618.

@ozpau
Copy link
Author

ozpau commented Jan 18, 2025

Found a problem with this implementation. If you click "Open in Notebook", then it will open notebook in system browser instead of jupyterlab-desktop.

@ozpau
Copy link
Author

ozpau commented Jan 19, 2025

While working on this I discovered another problem (that is also present in the upstream):

  1. Opening jupyter notebook from jupyter lab creates a window that is not decorated like main labview
  2. Opening external links in jupyter windows opened from jupyter labs doesn't use system browser
  3. Opening jupyter lab from jupyter notebook creates an undecorated window

@ozpau ozpau marked this pull request as draft January 26, 2025 20:16
@ozpau ozpau marked this pull request as ready for review February 5, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ozpau