Skip to content

Conversation

@nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Dec 11, 2025

Getting the list of all chats in the Open a chat drop-down like as same as we get in @jupyter-chat.

Screencast.From.2025-12-11.22-26-23.mp4

Now this PR also disables the disposing of chat model when chat is closed or moved to main area.

Screencast.From.2025-12-12.08-44-40.mp4

cc @brichet @jtpio

@nakul-py nakul-py changed the title Implementing chats list Getting all chats in list Dec 11, 2025
@nakul-py nakul-py marked this pull request as ready for review December 11, 2025 17:01
@nakul-py nakul-py marked this pull request as draft December 11, 2025 17:56
@nakul-py nakul-py marked this pull request as ready for review December 12, 2025 03:19
@brichet
Copy link
Collaborator

brichet commented Dec 12, 2025

Thanks @nakul-py for working on this.

I can see several problems with this implementation, this is why I suggested to implement it in @jupyter/chat:

  • there is no way to totally remove a model. This means that if you opened a lot of models, they will all be in the list, even if you don't need it anymore
  • from the previous problem, renaming a chat with a former name will not work (and currently it fails silently, maybe we should also fix it separately)
  • closing the chat with the cross actually dispose of the model. Currently everything works, nothing append when the model is disposed, but we should use a disposed chat, the behavior can be inconsistent in future.

@nakul-py
Copy link
Contributor Author

there is no way to totally remove a model. This means that if you opened a lot of models, they will all be in the list, even if you don't need it anymore

This problem will be solved by jupyterlab/jupyter-chat#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the list of opened chats

2 participants