Skip to content

Reject kernel ready promise when disposed #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
Merged

Reject kernel ready promise when disposed #238

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8fd888f
use a promise lock to serialize remote kernel initialization
bollwyvl Nov 17, 2025
07fd3a5
handle disposing
bollwyvl Nov 17, 2025
39cf7a6
avoid trying to initialize if already disposed
bollwyvl Nov 18, 2025
5cf1fe0
remove init lock, leave promise rejection
bollwyvl Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/pyodide-kernel/src/kernel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import { PromiseDelegate } from '@lumino/coreutils';

import { PageConfig } from '@jupyterlab/coreutils';

import { ILogPayload } from '@jupyterlab/logconsole';
import type { ILogPayload } from '@jupyterlab/logconsole';

import { Contents, KernelMessage } from '@jupyterlab/services';

import { BaseKernel, IKernel } from '@jupyterlite/kernel';

import {
import type {
ICoincidentPyodideWorkerKernel,
IComlinkPyodideKernel,
IPyodideWorkerKernel,
Expand Down Expand Up @@ -123,6 +123,7 @@ export class PyodideKernel extends BaseKernel implements IKernel {
});
}
const remoteOptions = this.initRemoteOptions(options);

remote
.initialize(remoteOptions)
.then(this._ready.resolve.bind(this._ready))
Expand All @@ -131,6 +132,7 @@ export class PyodideKernel extends BaseKernel implements IKernel {
payload: { type: 'text', level: 'critical', data: err.message },
kernelId: this.id,
});
this._ready.reject(err.message);
});
return remote;
}
Expand Down Expand Up @@ -168,6 +170,11 @@ export class PyodideKernel extends BaseKernel implements IKernel {
if (this.isDisposed) {
return;
}
try {
this._ready.reject(`${this.id} was disposed`);
} catch (err) {
// nothing to see here
}
this._worker.terminate();
(this._worker as any) = null;
super.dispose();
Expand Down