Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cypress): add tests for mit payment without billing #7326

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

likhinbopanna
Copy link
Contributor

@likhinbopanna likhinbopanna commented Feb 20, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added tests for payments made using CIT with billing address and MIT without a billing address.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Test cases Enhancement

How did you test it?

image image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@likhinbopanna likhinbopanna added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 20, 2025
@likhinbopanna likhinbopanna added this to the February 2025 Release milestone Feb 20, 2025
@likhinbopanna likhinbopanna self-assigned this Feb 20, 2025
@likhinbopanna likhinbopanna requested a review from a team as a code owner February 20, 2025 11:47
Copy link

semanticdiff-com bot commented Feb 20, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/e2e/configs/Payment/Commons.js  0% smaller
  cypress-tests/cypress/e2e/configs/Payment/Fiuu.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00019-MandatesUsingPMID.cy.js  0% smaller

@likhinbopanna likhinbopanna changed the title ci(cypress) : add tests for mit payment without billing ci(cypress): add tests for mit payment without billing Feb 20, 2025
Comment on lines 257 to 267
MITWithoutBillingAddress: {
Request: {
billing: null,
},
Response: {
status: 200,
body: {
status: "succeeded",
},
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel, it is better to be removed and just import from commons where ever it is same.

also, we can consider re-using it from configs.

what say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants