fix(routing): Fixed 5xx error logs in dynamic routing metrics #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Sarthak1799
changed the title
2 tasks
Chethan-rao
approved these changes
Feb 24, 2025
prajjwalkumar17
approved these changes
Feb 24, 2025
|
Latest code compiles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
A 5xx error log in DR metrics was spamming in alerts.
Have removed the log
Main PR - #7335
Additional Changes
Motivation and Context
How did you test it?
make a payment with dynamic routing enabled
5xx error log now converted to 4xx
Checklist
cargo +nightly fmt --allcargo clippy