Mandrill app mailer driver integration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/DataObjects/MailMessage.php # src/Mailer/MailerFactory.php
aprokopenko
commented
Jan 31, 2018
examples/form.php
Outdated
| $mailerConfig = [ | ||
| 'mailer' => MailHandler::USE_MANDRILL, // (or USE_POSTMARKAPP, USE_MANDRILL) | ||
| 'password' => '_5mPSvb39BQqnA7G_dOaAA', | ||
| 'attachmentsSizeLimit' => 8000000, // around 8MB. | ||
| ]; |
There was a problem hiding this comment.
I prefer to have another example for mandrill to keep files simple.
Let's rename files as:
- form2email-basic.php
- form2email-mandrill.php
src/Mailer/MandrillMailer.php
Outdated
|
|
||
| $mandrillMessage = array( | ||
| 'html' => $message->getBody(), | ||
| 'text' => 'Example text content', |
src/Mailer/MandrillMailer.php
Outdated
| } | ||
|
|
||
| $mandrillMessage['to'] = $toArray; | ||
| } |
There was a problem hiding this comment.
a bit of spaghetti code. $toArray should be defined before if() - otherwise you can get undefined var.
and you can write 1 code for all parts like:
$recipients = ['to' => $message->getTo(), 'cc' => $message->getCc(), ...]
foreach($recipients as $type => $emails) {
if (empty($emails)) continue;
foreach($emails as $email) {
$to[] = [email, name, type => $type]
}
}
src/Mailer/MandrillMailer.php
Outdated
| } | ||
|
|
||
| $async = false; | ||
| $ip_pool = 'Main Pool'; |
examples/form.php
Outdated
| // Mandrill config. | ||
| $mailerConfig = [ | ||
| 'mailer' => MailHandler::USE_MANDRILL, // (or USE_POSTMARKAPP, USE_MANDRILL) | ||
| 'password' => '_5mPSvb39BQqnA7G_dOaAA', |
There was a problem hiding this comment.
it's not password - it's apiKey!
aprokopenko
commented
Jan 31, 2018
src/Mailer/MandrillMailer.php
Outdated
| ); | ||
|
|
||
| // Recipients. | ||
| $recipients = ['to' => $message->getTo(), 'cc' => $message->getCc(), 'bcc' => $message->getBcc()]; |
There was a problem hiding this comment.
make normal format :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.