Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-radio): DSW-2307 add basic component functionality #1859

Merged
merged 17 commits into from
Sep 19, 2024

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Sep 13, 2024

Describe your changes (can list changeset entries if preferable)

  • [Added] - checked, defaultChecked, disabled, name, required and value props

Added tests covering checked, disabled and required props.

To prevent this PR from becoming too large, I will add the form reset behaviour and tests for the remaining props in a second PR.

In my opinion, visual tests should be added as part of the styling ticket.


Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook PR preview
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - Maryia

  • I have reviewed the PIE Storybook PR preview

Reviewer 2

  • I have reviewed the PIE Storybook PR preview

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: ef9823a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@justeattakeaway/pie-radio Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram xander-marjoram self-assigned this Sep 13, 2024
@xander-marjoram xander-marjoram marked this pull request as ready for review September 16, 2024 10:10
@xander-marjoram xander-marjoram requested review from a team as code owners September 16, 2024 10:10
@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

Copy link
Contributor

@dandel10n dandel10n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left only a few minor comments

dandel10n
dandel10n previously approved these changes Sep 17, 2024
# Conflicts:
#	apps/pie-storybook/stories/pie-radio.stories.ts
dandel10n
dandel10n previously approved these changes Sep 17, 2024
@xander-marjoram xander-marjoram merged commit 3450fbb into main Sep 19, 2024
32 of 33 checks passed
@xander-marjoram xander-marjoram deleted the dsw-2307-pie-radio branch September 19, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants