-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-radio): DSW-2307 add basic component functionality #1859
Conversation
🦋 Changeset detectedLatest commit: ef9823a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
faeaf4f
to
9053f4c
Compare
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left only a few minor comments
# Conflicts: # apps/pie-storybook/stories/pie-radio.stories.ts
cdffcb5
to
616a30d
Compare
Describe your changes (can list changeset entries if preferable)
checked
,defaultChecked
,disabled
,name
,required
andvalue
propsAdded tests covering
checked
,disabled
andrequired
props.To prevent this PR from becoming too large, I will add the form reset behaviour and tests for the remaining props in a second PR.
In my opinion, visual tests should be added as part of the styling ticket.
Author Checklist (complete before requesting a review)
PIE Storybook
PR preview/snapit
functionality to test my changes in a consuming applicationReviewer checklists (complete before approving)
Reviewer 1 - Maryia
PIE Storybook
PR previewReviewer 2
PIE Storybook
PR preview