-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pie-monorepo): DSW-2400 refactor generate:component-statuses
script
#1838
Conversation
🦋 Changeset detectedLatest commit: 7a80c5e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
948ba0b
to
e1db9a2
Compare
generate:component-statuses
script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but happy to merge as is, as I don't think there's any harm in being explicit with which package task needs to run 👍🏼
6bc77b7
Describe your changes (can list changeset entries if preferable)
generate:component-statuses
build.copy:component-statuses
script forpie-docs
andpie-storybook
which copies the status file from the root instead of building it from scratch in three different places.copy:component-statuses
can be run from the root, or filtered topie-docs
/pie-storybook
. It will automatically triggergenerate:component-statuses
to run.The generate script uses caching, with the
package.json
file for all of the components as inputs. So if none of these files have changed, the cache will be hit.The copy script doesn't use caching because it's just copying a single file, so there isn't really anything to be gained.
Example logs of the build working as expected:
Author Checklist (complete before requesting a review)
PIE Storybook
PR previewPIE Docs
PR preview