Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-monorepo): DSW-2400 refactor generate:component-statuses script #1838

Merged
merged 16 commits into from
Sep 17, 2024

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Sep 11, 2024

Describe your changes (can list changeset entries if preferable)

  • [Added] - Caching for generate:component-statuses build.
  • [Added] - New copy:component-statuses script for pie-docs and pie-storybook which copies the status file from the root instead of building it from scratch in three different places.
  • [Fixed] - A linting warning in the docs site, and I aligned the exports in a few other files at the same time to avoid the need to disable eslint

copy:component-statuses can be run from the root, or filtered to pie-docs/pie-storybook. It will automatically trigger generate:component-statuses to run.

The generate script uses caching, with the package.json file for all of the components as inputs. So if none of these files have changed, the cache will be hit.

The copy script doesn't use caching because it's just copying a single file, so there isn't really anything to be gained.

Example logs of the build working as expected:

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook PR preview
  • I have reviewed the PIE Docs PR preview

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 7a80c5e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram xander-marjoram self-assigned this Sep 11, 2024
@xander-marjoram xander-marjoram marked this pull request as ready for review September 12, 2024 07:56
@xander-marjoram xander-marjoram requested review from a team as code owners September 12, 2024 07:56
@xander-marjoram xander-marjoram force-pushed the dsw-2400-component-statuses branch from 948ba0b to e1db9a2 Compare September 12, 2024 10:48
@xander-marjoram xander-marjoram changed the title ci(pie-monorepo): DSW-2400 refactor generate:component-statuses script ci(pie-monorepo): DSW-2400 refactor generate:component-statuses script Sep 12, 2024
fernandofranca
fernandofranca previously approved these changes Sep 12, 2024
jamieomaguire
jamieomaguire previously approved these changes Sep 13, 2024
siggerzz
siggerzz previously approved these changes Sep 16, 2024
Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but happy to merge as is, as I don't think there's any harm in being explicit with which package task needs to run 👍🏼

@xander-marjoram xander-marjoram merged commit 8b1f579 into main Sep 17, 2024
55 checks passed
@xander-marjoram xander-marjoram deleted the dsw-2400-component-statuses branch September 17, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants