Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-tag): DSW-2550 pie tag icon only mode #2253

Merged
merged 11 commits into from
Mar 6, 2025

Conversation

fernandofranca
Copy link
Contributor

@fernandofranca fernandofranca commented Mar 3, 2025

Describe your changes (can list changeset entries if preferable)

@justeattakeaway/pie-tag

[Added] - supporting code for icon only mode
[Updated] - fixed padding in icon only mode

pie-storybook

[Added] - regular story for Tag icon only mode
[Added] - test stories for Tag icon only mode

pie-docs

[Added] - page for Tag icon only mode
[Updated] - content for Tag page regarding icon only mode

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists - Maryia

Reviewer 1

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

@fernandofranca fernandofranca requested review from a team as code owners March 3, 2025 11:03
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: e68f2f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-tag Minor
pie-storybook Minor
pie-docs Minor
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

raoufswe
raoufswe previously approved these changes Mar 3, 2025
dandel10n
dandel10n previously approved these changes Mar 3, 2025
@fernandofranca fernandofranca dismissed stale reviews from dandel10n and raoufswe via d6c0d7f March 4, 2025 16:13
@fernandofranca fernandofranca force-pushed the dsw-2550-pie-tag-icon-only-2 branch from 7604c19 to d6c0d7f Compare March 4, 2025 16:13
@fernandofranca fernandofranca merged commit 2774a61 into main Mar 6, 2025
29 checks passed
@fernandofranca fernandofranca deleted the dsw-2550-pie-tag-icon-only-2 branch March 6, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants