Skip to content

Conversation

@justinsaws
Copy link
Owner

What was the problem/requirement? (What/Why)

What was the solution? (How)

What is the impact of this change?

How was this change tested?

See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests?
  • Have you run the integration tests?
  • Have you made changes to the download or asset_sync modules? If so, then it is highly recommended
    that you ensure that the docker-based unit tests pass.

Was this change documented?

  • Are relevant docstrings in the code base updated?
  • Has the README.md been updated? If you modified CLI arguments, for instance.

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change?

A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Contracts section
of the DEVELOPMENT.md for more information on the public contracts.

If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
@justinsaws justinsaws force-pushed the refctor/qt_mvc_refactor branch from fbe6117 to b1cf615 Compare January 22, 2026 17:39
Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com>
@justinsaws justinsaws force-pushed the refctor/qt_mvc_refactor branch from b1cf615 to 782d94a Compare January 22, 2026 20:05
lucaseck and others added 2 commits January 22, 2026 14:23
Signed-off-by: lucaseck <117225985+lucaseck@users.noreply.github.com>
Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com>
@justinsaws justinsaws force-pushed the refctor/qt_mvc_refactor branch 2 times, most recently from 673d308 to 8c2afe9 Compare January 22, 2026 21:17
@justinsaws justinsaws force-pushed the refctor/qt_mvc_refactor branch from 8c2afe9 to 2ebdb4b Compare January 22, 2026 21:27
…rations

Replace direct Python threading with DeadlineUIController singleton
pattern for async AWS API operations. Adds AsyncTaskRunner for automatic
cancellation of superseded requests, JobSubmissionWorker for job
submission, and dedicated DeadlineThreadPool.

Refactors deadline_config_dialog, submit_job_progress_dialog, and
shared_job_settings_tab to use the new controller pattern, improving
thread safety and simplifying cancellation handling.

Signed-off-by: Justin Sawatzky <132946620+justinsaws@users.noreply.github.com>
@justinsaws justinsaws force-pushed the refctor/qt_mvc_refactor branch from 2ebdb4b to 68c23c6 Compare January 22, 2026 21:30
@justinsaws justinsaws closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants