Qty selector by justyna-13 · Pull Request #5 · justyna-13/storefront-ui

justyna-13 · 2020-03-30T10:13:42Z

Related issue

Closes #

Scope of work

Screenshots of visual changes

Checklist

No commented blocks of code left
Run tests and docs
Self code-reviewed

If applicable:

I followed composition rules for my component
I tested the component in most common device sizes (can be tested in Storybook from viewport addon in top menu)

* fix: font-weight variable * fix: semicolon

* refactor: add badge on mobile * refactor: adjust sfcolor styles * refactor: use color-size var

* refactor: negative icon color changed

* feat: adjusted SfBadge designs * refactor: adjusted font for badge * fix: moved font up

* refactor: adjust SfButton styling * refactor: added background fix for button * chore: removed commented block * refactor: adjusted font * refactor: changed api SfButton * fix: removed unused object knob * chore: added missing slot description * fix: adjusted underline modifier * fix: fixed issues with border * Update packages/vue/src/components/atoms/SfButton/SfButton.stories.js Co-Authored-By: Przemek Spaczek <pspaczek@divante.co> * fix: transition and slot icon * fix: --text padding Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: changes typography global variables * refactor: changes layout global variables * fix: typo Co-Authored-By: Anna Musial <ania.musial13@gmail.com>

* refactor: spacer in SfColor * refactor: spacer and font in SfBadge * refactor: spacer and font in SfButton

* fix: z-index in SfHeader * fix: ssr in SfHeader * refactor: use CSS class to showSearchOnMobile

- @storefront-ui/shared@0.6.2 - @storefront-ui/vue@0.6.2

…stem

* refactor: SfCheckbox styles * refactor: updated check icon * refactor: SfCheckbox stories updated * refactor: SfCheckbox add valid prop and class * fix: fix issues, clean code * fix: name of size variable Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* feat: improved SfBullets * refactor: cr fixes * refactor: clean code, color rgba, transition * refactor: cr fixes Co-authored-by: Marta Radziszewska <marta.radziszewskaa@gmail.com>

* refactor: adjust SfHeading * refactor: add heading with level class * refactor: add styles for levels * fix: lint

* refactor: added hover state and left, right modifiers * refactor: all CR bugs fixed Co-authored-by: Adam Pawliński <apawlinski@divante.pl>

* fix: implement h1 styles, changed heading sizes * fix: default heading level Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: adjusted styles * refactor: remove width and height variables Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: adjusted styles * refactor: removed bordered modifier, add diabled * refactor: add disabled, add v-focus, add chevron * refactor: changed box-shadow * refactor: fix padding, typo * refactor: updated width in stories * fix: removed v-focus, add missing disabled color * refactor: removed focus imports * refactor: small spacers improvements Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: tabs w/o transition * refactor: tabs with transition * refactor: cr fixes * fix: remove transition * refactor: small styles adjustment Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: adjusted SfGallery * refactor: adjusting SfGallery on mobile * chore: cleanig up the styles * refactor: adjust to code review * refactor: remove unnecessary code Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: added title slot to menu item * refactor: add asideTtitle prop, updated stories, awaiting for banner * refactor: add menu item to column * refactor: adjusted styles, changed menu item * refactor: CR fixes * fix: remove title props from SfMenuItem * fix: remove styles for title from SfMenuItem * fix: remove SfMenuItem from MegaMenuColumn title * fix: remove asideTitle * fix: flex align items on SfBanner * fix: aside stories for SfMegaMenu * fix: reset padding in storybook * fix: remove border from SfMenuItem * feat: add SfList to stories for MenuItems * fix: inline style in SfMegaMenu * feat: add border to SfList * fix: style for MegaMenu * fix: style for MegaMenu Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: adjust SfChevron * chore: remove unused styles * chore: adjusted paddings * refactor: added border behavior * chore: adjusted spacers and paddings * chore: fixed padding * chore: removed calc * refactor: remove chevron wrapper * refactor: remove chevron wrapper * fix: no idea * chore: lint Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: adjusted styles * refactor: fix double pics, slots only on desktop * refactor: updated stories * refactor: reorganized structure, add v-focus * feat: add wrapper for SfProductCardHorizontal stories * feat: add wrap css to SfButton * fix: remove desktop-only * fix: small adjustment * chore: adjust stories to design * chore: few small improvements Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* fix: adjust SfBanner min-height * fix: override bug * refactor: adjust SfBannerGrid to design system * fix: override bug on SfBanner

* refactor: adjust SfGrouped * refactor: adjusted stories and basic styling * Update packages/shared/styles/components/organisms/SfGroupedProduct.scss Co-Authored-By: Marta Radziszewska <marta.radziszewskaa@gmail.com> * Update packages/shared/styles/components/organisms/SfGroupedProduct.scss Co-Authored-By: Marta Radziszewska <marta.radziszewskaa@gmail.com> * chore: added line height * chore: removed unused font * refactor: adjusted template structure * chore: adjusted stories * refactor: added computed hascarousel * chore: added hascarousel prop * refactor: added mobile observer * refactor: added ismobile logic for grouped * fix: carousel on GrupedProduct * fix: remove isMobile & hasCarousel * fix: adjust stories to design * fix: adjust SfImage size * feat: toggle SfQuantitySelector and adjust style * fix: font for title * fix: glide * fix: font Co-authored-by: Marta Radziszewska <marta.radziszewskaa@gmail.com> Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: content pages adjust style in progress * refactor: adjust style in progress * refactor: style adjusting in progress * refactor: adjust style in progress * refactor: content pages adjust style * refactor: add border mixin * fix: adjust to mobile * fix: small improvements * feat: use SfHeading * chore: back to SfContentPages without SfHeading Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* refactor: fixed fonts and added missing icon * refactor: adjusted SfStoreLocator desktop view * refactor: adjusted differences in desktop and mobile * refactor: adjusted content SfStoreLocator * chore: fixed margin * fix: adjusted to CR changes * fix: marker icon * refactor: few small improvements Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* chore: add placeholder mixin to layout helpers * chore: placeholder prop, missing desc * feature: add class modifiers * feature: add stories, update props * chore: changed font size * chore: stories lint * fix: changed color of placeholder * feature: removed placeholder, add filled modifier with label

…ront#906) * chore: add phone icon to icons list * feat: refactor SfStoreLocator and SfStore - use pascal case - change to 1 level BEM and do not nest too much - add comment about using `registerStore` in template - add more slots in SfStore - expose locateUser in scope and provide * fix: move css import to scss to avoid jest issues Co-authored-by: Przemek Spaczek <pspaczek@divante.pl>

…nt#945)

- @storefront-ui/shared@0.6.3 - @storefront-ui/vue@0.6.3

* fix: font-size in Sfheading * refactor: change structure to adjust design * refactor: adjusted styles * refactor: add customClass to change modifier * refactor: updated paddings * refactor: updated stories * refactor: clean code * refactor: updated pages with sidebar to test * refactor: updated styles, add icon modifier * refactor: updated stories, add story with right ver * refactor: conditional display of sticky bottom, move bar on the top * refactor: updated pages with sidebar * refactor: remove SfIcon modifier * refactor: set to empty subtitle * refactor: change --sidebar-aside to just --sidebar * refactor: scss improvements * refactor: rename sticky-bottom to bottom * refactor: remove box-shadow from SfCircleIcon * fix: right side SfCircleIcon * feat: add content-top slot * fix: css variables overriding in SfHeading Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

* fix: error with building 0.6.3 * fix: use exact version of shared package * chore: add change from PR vuestorefront#948

- @storefront-ui/shared@0.6.4 - @storefront-ui/vue@0.6.4

…nt#955) * fix: focus directive events binding (vuestorefront#943) * refactor(organisms): SfStoreLocator - adjust to SFUI rules (vuestorefront#906) * chore: add phone icon to icons list * feat: refactor SfStoreLocator and SfStore - use pascal case - change to 1 level BEM and do not nest too much - add comment about using `registerStore` in template - add more slots in SfStore - expose locateUser in scope and provide * fix: move css import to scss to avoid jest issues Co-authored-by: Przemek Spaczek <pspaczek@divante.pl> * feat: add number prop type for SfSelect & SfSelectOption (vuestorefront#945) * chore(release): publish - @storefront-ui/shared@0.6.3 - @storefront-ui/vue@0.6.3 * fix: leaflet.css import (vuestorefront#953) * fix: error with building 0.6.3 * fix: use exact version of shared package * chore: add change from PR vuestorefront#948 * chore(release): publish - @storefront-ui/shared@0.6.4 - @storefront-ui/vue@0.6.4 * refactor: adjust SfStoreLocator to design system after merge Co-authored-by: Anna Musial <amusial@divante.pl> Co-authored-by: Nicolò Maria Mezzopera <nicolo.mezzopera@gmail.com> Co-authored-by: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>

…stem # Conflicts: # packages/shared/styles/components/organisms/SfStoreLocator.scss # packages/vue/src/components/organisms/SfStoreLocator/_internal/SfStore.vue

Przemek Spaczek and others added 30 commits March 2, 2020 10:37

fix: font sizes variables (vuestorefront#818)

101f2e5

fix: font-weight variables (vuestorefront#821)

7eccc08

* fix: font-weight variable * fix: semicolon

fix: title props name in SfSidebar (vuestorefront#810)

9f622ed

fix: badge icon radius (vuestorefront#811)

3d1f1d5

refactor(atoms): SfColor (vuestorefront#820)

8db4a8a

* refactor: add badge on mobile * refactor: adjust sfcolor styles * refactor: use color-size var

refactor(atoms): SfRating (vuestorefront#825)

f202309

* refactor: negative icon color changed

refactor(atoms): SfBadge (vuestorefront#817)

9ef30a6

* feat: adjusted SfBadge designs * refactor: adjusted font for badge * fix: moved font up

feat: disabled gray color varible (vuestorefront#822)

7775263

refactor(atoms): SfOverlay (vuestorefront#838)

e4758e1

fix: global variables (vuestorefront#843)

b08159a

* refactor: changes typography global variables * refactor: changes layout global variables * fix: typo Co-Authored-By: Anna Musial <ania.musial13@gmail.com>

refactor: adjust to changes in global variables (vuestorefront#844)

e400eec

* refactor: spacer in SfColor * refactor: spacer and font in SfBadge * refactor: spacer and font in SfButton

fix: ssr error in SfHeader(vuestorefront#854)

5332200

* fix: z-index in SfHeader * fix: ssr in SfHeader * refactor: use CSS class to showSearchOnMobile

fix: ssr in SfScrollable (vuestorefront#855)

2c1059f

docs: reorder core team members

25da463

Merge remote-tracking branch 'origin/develop'

44163af

chore(release): publish

283101a

- @storefront-ui/shared@0.6.2 - @storefront-ui/vue@0.6.2

Merge remote-tracking branch 'origin/develop' into refactor/design-sy…

d5b6b40

…stem

refactor: progress bar w/o dot

cdefad8

feat: add 4px and 32px spacer

eae0f72

refactor(atoms): SfBullets (vuestorefront#824)

545a61e

* feat: improved SfBullets * refactor: cr fixes * refactor: clean code, color rgba, transition * refactor: cr fixes Co-authored-by: Marta Radziszewska <marta.radziszewskaa@gmail.com>

refactor: transform in SfBullets

11ef91b

refactor(atoms): SfHeading (vuestorefront#826)

7ab92aa

* refactor: adjust SfHeading * refactor: add heading with level class * refactor: add styles for levels * fix: lint

refactor: fix font-family variable

c3d6734

fix: variables names in SfHeading

0dd05a3

refactor: SfImage (vuestorefront#836)

d5a2bc8

refactor(atoms): SfChevron (vuestorefront#827)

063b373

* refactor: added hover state and left, right modifiers * refactor: all CR bugs fixed Co-authored-by: Adam Pawliński <apawlinski@divante.pl>

refactor: bar progress with dots

df45ab4

fix: small adjustment in SfChevron

90b14b3

martaradziszewska and others added 30 commits March 19, 2020 14:18

refactor: add border mixin to SfDivider (vuestorefront#916)

50dc211

fix: implement h1 styles, changed heading sizes (vuestorefront#915)

0b1565a

* fix: implement h1 styles, changed heading sizes * fix: default heading level Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

refactor(molecules): SfProductOption (vuestorefront#905)

f8270db

* refactor: adjusted styles * refactor: remove width and height variables Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

refactor(organisms): SfTabs (vuestorefront#897)

2f7a15f

* refactor: tabs w/o transition * refactor: tabs with transition * refactor: cr fixes * fix: remove transition * refactor: small styles adjustment Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

refactor(molecules): SfGallery (vuestorefront#910)

d2e5c66

* refactor: adjusted SfGallery * refactor: adjusting SfGallery on mobile * chore: cleanig up the styles * refactor: adjust to code review * refactor: remove unnecessary code Co-authored-by: Przemek Spaczek <pspaczek@divante.co>

fix: content width and border for SfTabs

8e9d9da

refactor(organisms): SfBannerGrid (vuestorefront#929)

6776557

* fix: adjust SfBanner min-height * fix: override bug * refactor: adjust SfBannerGrid to design system * fix: override bug on SfBanner

chore: lint organisms components

3acd151

fix: font size for category title on SfContentPages

e172351

fix: focus directive events binding (vuestorefront#943)

8c32596

feat: add number prop type for SfSelect & SfSelectOption (vuestorefro…

2da1b49

…nt#945)

chore(release): publish

e9055f9

- @storefront-ui/shared@0.6.3 - @storefront-ui/vue@0.6.3

fix: color css global variable

b1fc7c1

fix: lint after refactor

2e16324

fix: position of CircleButton in SfSidebar

8087eee

fix: leaflet.css import (vuestorefront#953)

3a6c7a3

* fix: error with building 0.6.3 * fix: use exact version of shared package * chore: add change from PR vuestorefront#948

chore(release): publish

14c26a7

- @storefront-ui/shared@0.6.4 - @storefront-ui/vue@0.6.4

fix: reset padding on button in SfColor

ab81873

Merge remote-tracking branch 'origin/develop' into refactor/design-sy…

700dade

…stem # Conflicts: # packages/shared/styles/components/organisms/SfStoreLocator.scss # packages/vue/src/components/organisms/SfStoreLocator/_internal/SfStore.vue

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qty selector#5

Qty selector#5
justyna-13 wants to merge 132 commits intorefactor/design-systemfrom
bug/items-quantity-only-positive-integer

justyna-13 commented Mar 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

justyna-13 commented Mar 30, 2020

Related issue

Scope of work

Screenshots of visual changes

Checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants