Skip to content

PR : 핫픽스 해결 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuhyun1 merged 2 commits into from
Mar 4, 2025
Merged

PR : 핫픽스 해결 #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9fc6d9
[Hotfix] fix : 프로필 수정 시 이미지 요청이 있으면 업데이트, 없으면 기존 이미지 삭제되게 변경
yuhyun1 Mar 4, 2025
8a9cfa6
[Hotfix] fix : 프로필 수정 시 이미지 요청이 있으면 업데이트, 없으면 기존 이미지 삭제되게 변경
yuhyun1 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/juu/juulabel/api/service/member/MemberService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,12 @@ public boolean checkNickname(String nickname) {
public UpdateProfileResponse updateProfile(Member loginMember, UpdateProfileRequest request, MultipartFile image) {
Member member = memberReader.getByEmail(loginMember.getEmail());

String profileImageUrl = null;
if (image != null) {
UploadImageInfo uploadImageInfo = s3Service.uploadMemberProfileImage(image);
member.updateProfile(request, uploadImageInfo.ImageUrl());
} else {
member.updateProfileWithoutImage(request);
profileImageUrl = uploadImageInfo.ImageUrl();
}
member.updateProfile(request, profileImageUrl);

memberAlcoholTypeWriter.deleteAllByMember(member);

Expand Down
6 changes: 0 additions & 6 deletions src/main/java/com/juu/juulabel/domain/entity/member/Member.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,6 @@ public void updateProfile(UpdateProfileRequest request, String profileImageUrl)
this.gender = request.gender();
}

public void updateProfileWithoutImage(UpdateProfileRequest request) {
this.nickname = request.nickname();
this.introduction = request.introduction();
this.gender = request.gender();
}

public void deleteAccount() {
this.deletedAt = LocalDateTime.now();
this.profileImage = null;
Expand Down