Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --fail-fast #1040

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Fix --fail-fast #1040

merged 4 commits into from
Sep 14, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Sep 14, 2024

@k1LoW k1LoW added the bug Something isn't working label Sep 14, 2024
@k1LoW k1LoW self-assigned this Sep 14, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1040 (ca5a19d) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,948,638,999 ns/op 3,756,259,444 ns/op -192,379,555 ns/op
Bytes allocated per iteration 1,786,024,944 B/op 1,785,812,240 B/op -212,704 B/op
Allocs per iteration 21,134,703 allocs/op 21,134,947 allocs/op 244 allocs/op
Metadata
main (-) #1040 (ca5a19d)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1040 (ca5a19d) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,619,856,322 ns/op 4,670,145,188 ns/op 50,288,866 ns/op
Bytes allocated per iteration 2,218,361,448 B/op 2,218,153,576 B/op -207,872 B/op
Allocs per iteration 30,852,027 allocs/op 30,849,360 allocs/op -2,667 allocs/op
Metadata
main (-) #1040 (ca5a19d)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1040 (ca5a19d) +/-
Number of iterations 18 19 1
Nanoseconds per iteration 63,349,655 ns/op 63,239,014 ns/op -110,641 ns/op
Bytes allocated per iteration 60,118,141 B/op 60,116,924 B/op -1,217 B/op
Allocs per iteration 205,396 allocs/op 205,395 allocs/op -1 allocs/op
Metadata
main (-) #1040 (ca5a19d)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (1d8639a) #1040 (ca5a19d) +/-
Coverage 64.4% 64.4% -0.1%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 6m33s 5m42s -51s
Details
  |                     | main (1d8639a) | #1040 (ca5a19d) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          64.4% |           64.4% | -0.1% |
  |   Files             |             78 |              78 |     0 |
  |   Lines             |           8697 |            8700 |    +3 |
+ |   Covered           |           5604 |            5605 |    +1 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |  -0.1 |
  |   Code              |          15995 |           16000 |    +5 |
  |   Test              |          11629 |           11629 |     0 |
+ | Test Execution Time |          6m33s |           5m42s |  -51s |

Code coverage of files in pull request scope (74.8% → 74.7%)

Files Coverage +/-
flags/flags.go 0.0% 0.0%
operator.go 80.5% -0.2%

Reported by octocov

@k1LoW k1LoW merged commit 4e8be38 into main Sep 14, 2024
8 checks passed
@k1LoW k1LoW deleted the fix-fail-fast branch September 14, 2024 12:49
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] How does the --fail-fast option affect the runn run behavior?
1 participant