Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle err of operators on Run/RunN #1042

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix handle err of operators on Run/RunN #1042

merged 1 commit into from
Sep 15, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Sep 15, 2024

SSIA.

ref: #1032

@k1LoW k1LoW added bug Something isn't working breaking-change labels Sep 15, 2024
@k1LoW k1LoW self-assigned this Sep 15, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1042 (7b7720e) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,819,181,459 ns/op 3,803,803,974 ns/op -15,377,485 ns/op
Bytes allocated per iteration 1,786,437,856 B/op 1,786,644,520 B/op 206,664 B/op
Allocs per iteration 21,145,098 allocs/op 21,145,276 allocs/op 178 allocs/op
Metadata
main (-) #1042 (7b7720e)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1042 (7b7720e) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,719,066,369 ns/op 4,628,666,421 ns/op -90,399,948 ns/op
Bytes allocated per iteration 2,217,939,680 B/op 2,218,330,352 B/op 390,672 B/op
Allocs per iteration 30,849,981 allocs/op 30,858,706 allocs/op 8,725 allocs/op
Metadata
main (-) #1042 (7b7720e)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1042 (7b7720e) +/-
Number of iterations 19 18 -1
Nanoseconds per iteration 64,438,939 ns/op 64,320,214 ns/op -118,725 ns/op
Bytes allocated per iteration 60,125,994 B/op 60,139,463 B/op 13,469 B/op
Allocs per iteration 205,510 allocs/op 205,513 allocs/op 3 allocs/op
Metadata
main (-) #1042 (7b7720e)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (12fdfe5) #1042 (7b7720e) +/-
Coverage 64.4% 64.4% -0.1%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 5m47s 6m1s +14s
Details
  |                     | main (12fdfe5) | #1042 (7b7720e) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          64.4% |           64.4% | -0.1% |
  |   Files             |             78 |              78 |     0 |
  |   Lines             |           8700 |            8702 |    +2 |
+ |   Covered           |           5604 |            5605 |    +1 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |  -0.1 |
  |   Code              |          16000 |           16005 |    +5 |
  |   Test              |          11629 |           11629 |     0 |
- | Test Execution Time |          5m47s |            6m1s |  +14s |

Code coverage of files in pull request scope (80.5% → 80.3%)

Files Coverage +/-
operator.go 80.3% -0.2%

Reported by octocov

@k1LoW k1LoW merged commit 238a272 into main Sep 15, 2024
8 checks passed
@k1LoW k1LoW deleted the fix-fail-fast branch September 15, 2024 06:15
@github-actions github-actions bot mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant