Skip to content

Support UMD#15

Open
kevinresol wants to merge 1 commit intokLabz:masterfrom
kevinresol:umd
Open

Support UMD#15
kevinresol wants to merge 1 commit intokLabz:masterfrom
kevinresol:umd

Conversation

@kevinresol
Copy link
Contributor

Support adding -D mui.global to switch to @:native generation so we can use UMD module without the build process

@kLabz
Copy link
Owner

kLabz commented Aug 12, 2020

Thanks, I'll check my other branches to sync and I'll merge 👍

@kevinresol
Copy link
Contributor Author

Just a regex find and replace in vscode:

@:jsRequire\('@material-ui/core', '(\w*)'\)

#if mui.global @:native('MaterialUI.$1') #else @:jsRequire('@material-ui/core', '$1') #end

@kLabz
Copy link
Owner

kLabz commented Aug 13, 2020

That doesn't cover all cases, though. See line 25 of Table.hx for example.

Edit: also, mui.lab and mui.icon packages

@kevinresol
Copy link
Contributor Author

I think there is no cdn-hosted umd-build for lab (or at least I can't find it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants