Skip to content

FE: Add dropdown action to re-produce existing message into topic (#247) #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benaskiburtas
Copy link

@benaskiburtas benaskiburtas commented Jul 21, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Added a new action to the message action dropdown as suggested on #247:
image

This is implemented via a hook useProduceMessage and TopicActionsContext to interact with the side-bar while avoiding prop drilling.

Action will prefill:

  • Partition
  • Key
  • Message content
  • Headers
  • Key Serde (currently selected)
  • Value Serde (currently selected)

SendMessage.tsx had some aria labels misconfigured, adjusted some properties slightly to point to actual labels.

Is there anything you'd like reviewers to focus on?

  • For the moment I linked this action to the same ResourceType.TOPIC & Action.MESSAGES_PRODUCE permissions, same as the existing standalone action. The initial issue description suggested a new permission specifically for reproducing a message (e.g. Action.MESSAGES_REPRODUCE?). Do let me know if that would be preferred; :)
  • I slightly struggled manually verifying RBAC roles are working correctly. Covered this case with a test but wouldn't hurt to double check;
  • Frontend isn't my strong suit, may have over-engineered with the new context component. Thought it could be used to add some more 'global' functionality later on. Do let me know if passing some props around more directly would be better;
  • It's my first PR to this project, any feedback is welcome and appreciated 💜

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
659373-2292747750

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 21, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi benaskiburtas! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@benaskiburtas benaskiburtas marked this pull request as ready for review July 21, 2025 22:36
@benaskiburtas benaskiburtas requested a review from a team as a code owner July 21, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant