Open
Conversation
e8afb92 to
169cef9
Compare
169cef9 to
6b42d40
Compare
6b42d40 to
8f7adcd
Compare
8f7adcd to
4d6e37f
Compare
…in spring config are fixed
4d6e37f to
c2a2c6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify polling strategy naming between documentation and Spring Boot config and additional readme refactoring
The polling strategy is referred to as
fetch-and-lock-on-executein the main documentation, but configured asfetchin Fluent API and Spring Boot application.properties.Specifying
fetch-and-lock-on-executein Spring configuration results in startup failure cause the enum expectsFETCHorLOCK_AND_FETCH:This inconsistency can be confusing for users. Changing the property name from fetch to
fetch-and-lock-on-executewould be a breaking change for existing users - that is why the note in docs is the optimal variant.Fixes
This PR adds explicit links between the two:
fetchcorresponds tofetch-and-lock-on-executeAlso additional refactoring:
Documentation is updated to clarify the mapping, helping users avoid this error.
Reminders
mvn spotless:applycc @kagkarlsson