Skip to content

fix: esm conflict issue without major#237

Open
kaisermann wants to merge 1 commit intomainfrom
esm-fix-patch
Open

fix: esm conflict issue without major#237
kaisermann wants to merge 1 commit intomainfrom
esm-fix-patch

Conversation

@kaisermann
Copy link
Owner

@kaisermann kaisermann commented Oct 14, 2023

Attempting to fix the esm/cjs conflict without a major bump due to adding pkg.exports to the package.json

@kaisermann kaisermann mentioned this pull request Oct 14, 2023
Closed
@kaisermann kaisermann changed the title fix: attempt to fix esm issue fix: attempt to fix esm issue without major Oct 14, 2023
@kaisermann kaisermann changed the title fix: attempt to fix esm issue without major fix: esm conflict issue without major Oct 14, 2023
benmccann
benmccann suggested changes Aug 8, 2025
View reviewed changes
Copy link

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're currently on 4.x and publint is already added:

svelte-i18n/package.json

Line 42 in 5afd1f8

"prepublishOnly": "pnpm test -- --no-cache && pnpm build && publint",

I think this PR could probably be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@benmccann benmccann benmccann requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaisermann @benmccann