Python3, improvements, typing and cleanup #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added typing, py.typed and kaitaistruct.pyi - Removed Python 2 support. Its dead, for real. Increased speed by around 15%.
Adjusted the setup.cfg file to reflect changes in version attribute location. This was to standardize the way the version number is handled and stored. Added __init__.py file for storing the version number, as it's a more standard practice. This will also avoid redundancy and potential inconsistencies in maintaining the version number at multiple places.
…py grabs it from metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. This is obviously not doable the next day but i thought i would share my ideas.