Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(metarepos): add specification to management RPCs #687

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jan 26, 2024

What this PR does

This PR adds specifications to "proto/mrpb/management.proto". This helps us
establish agreements for the contracts of the metadata repository's management
RPCs.

Which issue(s) this PR resolves

Update: #658

@ijsong
Copy link
Member Author

ijsong commented Jan 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c58a51d) 61.71% compared to head (358b8c6) 61.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   61.71%   61.86%   +0.14%     
==========================================
  Files         144      144              
  Lines       15934    15934              
==========================================
+ Hits         9834     9857      +23     
+ Misses       5496     5477      -19     
+ Partials      604      600       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong self-assigned this Jan 28, 2024
This PR adds specifications to "proto/mrpb/management.proto". This helps us
establish agreements for the contracts of the metadata repository's management
RPCs.

Update: #658
@ijsong ijsong merged commit 44d1ec0 into main Feb 6, 2024
18 checks passed
@ijsong ijsong deleted the mrpb_management_spec branch February 6, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants