Skip to content

Improved twitter cards#206

Closed
sergiandreplace wants to merge 3 commits intokakawait:developfrom
sergiandreplace:twitter-cards
Closed

Improved twitter cards#206
sergiandreplace wants to merge 3 commits intokakawait:developfrom
sergiandreplace:twitter-cards

Conversation

@sergiandreplace
Copy link

@sergiandreplace sergiandreplace commented Sep 29, 2017

Tagging of twitter cards was not really working fine (at least for me)

Added some values to make it more flexible/automated

@sergiandreplace sergiandreplace changed the base branch from master to develop September 29, 2017 21:23
@kakawait
Copy link
Owner

kakawait commented Oct 2, 2017

@sergiandreplace thank you for contribution. I will check that asap. Because I was plan to move in-house SSO feature like twitter card to https://github.com/gohugoio/hugo/blob/142558719324aa1628541d556ef1fa2d123f1e68/tpl/tplimpl/template_embedded.go#L159 (related to #54)

I should see if it will be compatible, if not I have to found a better solution to mix both world

@kakawait kakawait self-assigned this Oct 2, 2017
@sergiandreplace
Copy link
Author

Sure! Take your time for the best solution

@kakawait kakawait added this to the 0.4.4-BETA milestone Nov 18, 2017
@kakawait
Copy link
Owner

@sergiandreplace sorry for delay. After more research i think I will not use Hugo internal template in ordre to keep control of Social tag.

I'm currently working on it because I want to merge with other PR #216

Promise i will fix/enhance twitter card (Aka social tag) really soon. I already have a branch on local workspace

kakawait added a commit that referenced this pull request Nov 22, 2017
- Add more twitter meta tag
- Fix existing social tag
- Add link canonical

Merge both existing PR #206 and 216
kakawait added a commit that referenced this pull request Nov 22, 2017
- Add more twitter meta tag
- Fix existing social tag
- Add link canonical

Merge both existing PR #206 and 216
@kakawait
Copy link
Owner

I will close it in favor of #239

@kakawait kakawait closed this Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants