Skip to content

Add blogs showcase post#234

Merged
kakawait merged 1 commit intokakawait:developfrom
yamila-moreno:ISSUE/230/adding-showcase
Nov 18, 2017
Merged

Add blogs showcase post#234
kakawait merged 1 commit intokakawait:developfrom
yamila-moreno:ISSUE/230/adding-showcase

Conversation

@yamila-moreno
Copy link
Contributor

Here's the pull request, that also closes #228

  • I've edited README.md to point to the new post, instead of the wiki
  • I've used markdown, although it's not the fanciest view, it's probably the easiest to maintain and contribute

Any suggestions are welcome 👍

Copy link
Owner

@kakawait kakawait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else thank and great contribution

README.md Outdated
## Showcase

Checkout showcase https://github.com/kakawait/hugo-tranquilpeak-theme/wiki/Showcase
Checkout showcase https://tranquilpeak.kakawait.com/2015/06/blogs-showcase/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending of the rest of review URL may change. Just add note to do not forget :)

@@ -0,0 +1,38 @@
---
title: "Blogs showcase"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about title

Who's using Tranquilpeak hugo theme

- description (optional)


[![Eric Bouchut's blog](http://i.imgur.com/zQmKIKNm.png)](http://ericbouchut.com/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about section like following instead

## Eric Bouchut's blog

[![Eric Bouchut's blog](http://i.imgur.com/zQmKIKNm.png)](http://ericbouchut.com/)

I think using heading allow better separation between each blog post and better highlighting

@yamila-moreno yamila-moreno force-pushed the ISSUE/230/adding-showcase branch from bc36a92 to d9f1c2d Compare November 17, 2017 10:17
@yamila-moreno
Copy link
Contributor Author

Done!

@kakawait
Copy link
Owner

Nice I will merge it and update https://tranquilpeak.kakawait.com after work hours

@yamila-moreno
Copy link
Contributor Author

yamila-moreno commented Nov 17, 2017 via email

@kakawait kakawait changed the base branch from master to develop November 18, 2017 14:38
@kakawait kakawait added the showcase Add my site to showcase label Nov 18, 2017
@kakawait kakawait added this to the 0.4.4-BETA milestone Nov 18, 2017
@kakawait kakawait merged commit f7a9380 into kakawait:develop Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

showcase Add my site to showcase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments