Allow customJS for posts via metadata#262
Open
niklas88 wants to merge 1 commit intokakawait:developfrom
Open
Conversation
Owner
|
@niklas88 Thank you for contribution I think it will be nice to do the same thing for Do you think you can add that addition? Else no problem I will merge it like that and add after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows adding custom Javascript to posts in a way analogous to the global site.
To add a Javascript file to a post one only has to add a customJS option to the metadata like so
I'm not really happy with the code duplication but when I delete the
{{ range .Size.Params.customJS }}site widecustomJSbreaks. So I'm not sure if there's a better way. Also of course this still lacks documentation but I wanted to get a discussion started before writing that.