add more possibility for validation of password#22
Open
tburguie wants to merge 81 commits intokakwa:mainfrom
Open
add more possibility for validation of password#22tburguie wants to merge 81 commits intokakwa:mainfrom
tburguie wants to merge 81 commits intokakwa:mainfrom
Conversation
- Switch from base64 to URL encoding for the passing the URL, using the built-in Mako filtering - Apply HTML filtering to Mako output by default - Disable HTML filtering for nested templates in adduser, modify, and selfmodify
Protect against XSS vulnerabilities in URL redirection
- Use markupsafe to format escaped HTML fragments - Correct the formatting problems introduced with the XSS fixes
Escape form values with markupsafe
The templates were html escaping the generated js code for the autofill and the role management. This was breaking these features. It's okay to not escape these as they are coming from a trusted source (configuration file). Also make the templates python3 compatible (not need to import Set in python 3)
Sets are not available in mako templates when using python3. Reverting to using lists with 'if not in' checks to avoid duplication.
* changes in urllib imports since quote_plus in urllib with python 2 and in urllib.parse in python 3 * changes in imports for Sets since set is a native type in python 3 and doesn't requires an import * fix in __import__, '-1' level for module path discovery is not supported anymore, switching to 0 (absolute import only).
* switch from script to entry_points in setup.py * move the cli script in ldapcherry (to be used as a module) * put the __main__ code in a dedicated function constituting the entry point * add a few python3 environments in travis file
Now the escaping is done by in the templates. We need to remove the previous escaping done by hand in the code. Otherwise, we end-up with double escaping and funky displaying of fields.
The id of the user is passed through the querystring in this page. But the id was not properly escaped to be included as a querystring parameter leading to weird issues like.
Debug mode can lead to log sensitive data (like password changes). Having -D to log exclusively to stderr is a safer option.
previously, the default logger was passed, this logger was using the default configuration and log level, not honoring log level in particular. As a consequence, it was impossible to get debug logs from the backend. This is now working as expected.
* improve documentation for key: True flag in attributes.yml * improve documentation for the ldap filters and their templating * improve comment in the .ini file
pre-cleanup to avoid contamination if other tests fail
Add possibility to check for a certain number of lower, punctuation characters and a number of rule to check among min_lower, min_upper, min_digit, min_punct.
Owner
|
Hummm, the ppolicy simple is meant to be... simple, I think it would be a better feat for a more complex ppolicy module such as: https://github.com/kakwa/ldapcherry-ppolicy-cracklib/blob/master/lcppolicy_cracklib/__init__.py Also, setting default value might be a good idea: self.get_param('min_point')
self.get_param('min_point', 0)Otherwise it will introduce a breaking change in the configuration format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to check for a certain number of lower, punctuation
characters and a number of rule to check among min_lower, min_upper,
min_digit, min_punct.