fix(FEC-14966) - Add arrow key navigation and selection for True/Fals… - #206
Merged
Conversation
roeedean
requested changes
Jun 5, 2026
Comment on lines
+46
to
+47
| const navigateAndSelect = (currentIndex: number, direction: 'prev' | 'next') => { | ||
| const newIndex = direction === 'prev' ? currentIndex - 1 : currentIndex + 1; |
Contributor
There was a problem hiding this comment.
Suggestion - not a blocker:
direction: 'prev' | 'next' could be replaced with a numeric var like step: -1 | 1.
Suggested change
| const navigateAndSelect = (currentIndex: number, direction: 'prev' | 'next') => { | |
| const newIndex = direction === 'prev' ? currentIndex - 1 : currentIndex + 1; | |
| const navigateAndSelect = (currentIndex: number, step: -1 | 1) => { | |
| const newIndex = currentIndex + step; |
This is more direct and avoids the string comparison.
Contributor
Author
There was a problem hiding this comment.
Sounds good. Done!
Comment on lines
+55
to
+58
| const handleLeftKeyPressed = (currentIndex: number) => navigateAndSelect(currentIndex, 'prev'); | ||
| const handleRightKeyPressed = (currentIndex: number) => navigateAndSelect(currentIndex, 'next'); | ||
| const handleUpKeyPressed = (currentIndex: number) => navigateAndSelect(currentIndex, 'prev'); | ||
| const handleDownKeyPressed = (currentIndex: number) => navigateAndSelect(currentIndex, 'next'); |
Contributor
There was a problem hiding this comment.
If you decide to go with my suggestion above for func navigateAndSelect - update second var on each call:
'prev' -> -1
'next' -> 1
roeedean
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://kaltura.atlassian.net/browse/FEC-14966 by adding arrow key navigation for True-False questions as it is for Multi-choice questions