Using a Goertzel filter instead of using the fft#51
Using a Goertzel filter instead of using the fft#51aguaviva wants to merge 1 commit intokamalmostafa:masterfrom
Conversation
|
What's the difference between the two invocations of minimodem in your example? |
|
Ops! Nothing, I pasted twice the same invocation. I edited the comment to fix that and added how I generated the audio |
|
@kamalmostafa I hope you have a chance soon to look at this :) |
|
@aguaviva Yes, your Goertzel implementation is quite interesting! I'll set aside some time to review this and respond soon. |
Awesome! I'll be happy to answer any questions you may have :) |
|
Thanks for this! @aguaviva please see my email reply. Test merge here, on the tmp/aguaviva-goertzel branch: commit da66d40 Merge to master pending resolution of rx "ampl=" test-case failures: https://github.com/kamalmostafa/minimodem/runs/3093947230 |
|
Hi @aguaviva -- Did you receive my email 2021-07-17 Subject: "minimodem Goertzel implementataion"? Please reply, or let me know here if you didn't. |
|
hey, I am going to look at things now. Sorry for the delay. |
|
hey @kamalmostafa, please consider my PR a proof of concept and feel free to refactor it in anyway you see fit. |
|
Any updates on this? |
There you go!
generating the audio:
decoding the audio:
This 'should' close #50 although this is just a quick implementation and I am sure you will want to refactor things a big
Also, note that that Goertzel function is returning the magnitude squared, I'd need a square root but it is not really necessary.
Thanks for this project though!