Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new overlay and popup configuration options, allow to pass function which returns Element in element step config #508

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

enp-kbeda
Copy link

@enp-kbeda enp-kbeda commented Jul 15, 2024

Hello,
I'd like to propose these new features:

  • add new overlayEnable config option, enabled by default. This property allows library consumers to disable highlight overlay if they wish. (741f521)
    To keep the functionality of closing highlight when user clicks away I needed to add new window click listener when overlayEnable is set to false (ffbe505)
  • add new popoverStickToViewport config option, enabled by default. This property allows library consumers to disable popover viewport sticking. When it's set to false popover always stays next to the step.element (7fd1726)
  • allow to pass function which returns Element as step element config to allow better integration with frameworks like Vue.js which use element reference instead of document.querySelector (5d1ec41)
  • add new allowScroll config option, enabled by default. This property allows library consumers to disable body scrolling when driver is active (2d48c13)
  • add new animateBetweenSameElements config option, enabled by default. This property allows library consumers to disable popup animation when multiple steps are assigned to the same html element (be29918)
  • fixed wrong active element on requireRefresh calls which resulted in broken layout (video of the issue - https://drive.google.com/file/d/1JjQZuctRSwiBExAQDDFbALvIrsjdqHKK/view?usp=sharing) (b11d4e2)
  • do not scroll to popover as we already scroll to step.element - this fixes the issue where user could make it so element is not visible at all on the page - https://drive.google.com/file/d/1FDr8yNEsNc6onkIVNBBykxwFU5uCDEdD/view?usp=sharing (c86bf59)

I've added interactive examples of config options in index.html

@racingfoxs
Copy link

These are quite good feature.

@enp-kbeda
Copy link
Author

I have more but no time to update yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants