Conversation
2709cd6 to
62a3429
Compare
c08b9fd to
3b57f9c
Compare
3b57f9c to
a48c5ba
Compare
|
FWIW, the new demo site isn't intended to be a tutorial. There will be strange things that aren't applicable to a real app, and things that are missing. We have tutorials for 0.6 will be marked as a "stable" release when it's ready, and plenty of others have expressed significant interest in it... and I don't need a reminder. 😉 I've got quite a few things I want to look at still, that part will take time. |
favicon, fix logging
* show the actual `DomException` for `nav.cred.get()` errors * show an error when `nav.cred.create()` returns an unexpected error type * use `<ShowLet>` for views * encode credential ID as base64 for consistency with API * show JSON form of registration and authentication challenges
…on to server-side)
116758c to
375b1bc
Compare
|
The demo site is now near completion. I've tested this on mobile with the iOS Simulator (Device Hub), and it looks fine there. I still need to test this on Android, and I'll need to set up local HTTPS serving for that (due to networking differences). I anticipate some issues there due to Android's fragmented WebAuthn stack. |
Firstyear
left a comment
Firstyear
left a comment
There was a problem hiding this comment.
Looks good, ran it locally and it "just worked" which is always nice :)
| //! [`SessionCookie`] then stored in a [`Jwe`], which is encrypted with a key-wrapped key before | ||
| //! being sent to the client. This avoids the need to persist this data elsewhere in the server. | ||
| //! | ||
| //! While [`cookie`] has its own way to encrypt data, we discovered a security issue with its |
There was a problem hiding this comment.
It's no longer considered a security issue for the record, but this jwe usage is probably still better long term.
| Ok(passkey) | ||
| } | ||
|
|
||
| // TODO: memory management; removing excessive entries. |
2 participants
Change summary
Work in progress, do not merge!
This targets the 0.6 branch (#499 / #504) for convenience.
rustDocker image to buildwebauthn-rs-demo. While this is an "officially Docker" image, it is managed byrust-lang(unlike some other languages' "officially Docker" images).This also:
web-sys)clippylints for the tutorials to thetutorialCI job (added in Bugs2 #482)This also fixes some issues with CI where
web-syscan not be built on Windows in some circumstances, and moves checks for the tutorials to thetutorialsjob (#482).Depends on:
WebauthnCore::origins_matchtowebauthn-rs-proto, don't buildtidedocs in CI (#554 cherry-pick) #559opensslfrom Windows CI runners, webauthn-authenticator-rs CI cleanups #561 (touches same files)Fixes #555
TODO
Dropped features for MVP
/datavolume is lost, that'll clear everything out.Checklist