Merge branch 'DES/enhancement/732-vlc-refactor/hr' into DES/enhancement/

#732-vlc-refactor
kanselarij-vlaanderen · Apr 16, 2021 · 0199737 · 0199737
2 parents 025679c + a6b7c41
commit 0199737
Show file tree

Hide file tree

Showing 13 changed files with 32 additions and 22 deletions.
diff --git a/app/components/agenda/agenda-decisions.hbs b/app/components/agenda/agenda-decisions.hbs
@@ -20,7 +20,9 @@
             <p class="auk-u-text-bold auk-u-text-capitalized">
               {{await title}}
             </p>
-            <hr class="vlc-hr"/>
+            <div class="auk-hr">
+              <hr/>
+            </div>
           </div>
         </div>
         <div style="page-break-after:always;">

diff --git a/app/components/agenda/agenda-overview/agenda-overview-item.hbs b/app/components/agenda/agenda-overview/agenda-overview-item.hbs
@@ -96,7 +96,9 @@
         {{/if}}
       {{/if}}
       {{#unless @isEditingFormallyOkStatus}}
-        <div class="vlc-hr"></div>
+        <div class="auk-hr">
+          <hr/>
+        </div>
         <div class="vlc-agenda-items__remarks">
           <div>
             {{#if @agendaitem.explanation}}

diff --git a/app/components/agenda/agendaitem/agendaitem-case/all-subcases.hbs b/app/components/agenda/agendaitem/agendaitem-case/all-subcases.hbs
@@ -10,7 +10,9 @@
 {{else if @subcases.length}}
   {{#each @subcases as |subcase|}}
     <Subcases::SubcaseItem @subcase={{await subcase}} as |subcase|>
-      <hr class="vlc-hr"/>
+      <div class="auk-hr">
+        <hr/>
+      </div>
       <div class="auk-u-mb-4">
         <p>
           {{subcase.title}}

diff --git a/app/components/agenda/press-agenda.hbs b/app/components/agenda/press-agenda.hbs
@@ -10,7 +10,9 @@
     </h1>
   </div>
   <div class="auk-u-mb-8">
-    <hr class="vlc-hr"/>
+    <div class="auk-hr">
+      <hr/>
+    </div>
   </div>
   <div class="auk-u-mb-4">
     {{#each (await agendaitemGroups) as |agendaitemGroup|}}
@@ -59,7 +61,9 @@
             {{/if}}
           {{/each}}
           <div class="auk-u-mb-8">
-            <hr class="vlc-hr"/>
+            <div class="auk-hr">
+              <hr/>
+            </div>
           </div>
         </div>
       {{/if}}

diff --git a/app/components/domain-field-ise/domains-fields-selector-form.hbs b/app/components/domain-field-ise/domains-fields-selector-form.hbs
@@ -3,7 +3,9 @@
     <ul class="vlc-checkbox-tree">
       <li>
         {{#unless (eq index 0)}}
-          <div class="vlc-hr"></div>
+          <div class="auk-hr">
+            <hr/>
+          </div>
         {{/unless}}
         <WebComponents::VlCheckbox
           @value={{domainSelection.isSelected}}

diff --git a/app/components/newsletter/newsletter-meeting.hbs b/app/components/newsletter/newsletter-meeting.hbs
@@ -49,4 +49,6 @@
     }}
   {{/web-components/vl-modal}}
 {{/if}}
-<hr class="vlc-hr"/>
+<div class="auk-hr">
+  <hr/>
+</div>
diff --git a/app/components/subcases/subcases-process.hbs b/app/components/subcases/subcases-process.hbs
@@ -1,7 +1,9 @@
 <div class="auk-u-m-8">
   {{#each @subcases as |subcase|}}
     <Subcases::SubcaseItem @subcase={{subcase}} as |subcase|>
-      <hr class="vlc-hr"/>
+      <div class="auk-hr">
+        <hr/>
+      </div>
       <div class="auk-u-mb-2">
         <p class="vlc-subline">
           {{await subcase.case.type.label}}

diff --git a/app/components/utils/piece-details-edit.hbs b/app/components/utils/piece-details-edit.hbs
@@ -26,7 +26,9 @@
           </div>
         </div>
 
-        <div class="vlc-hr"></div>
+        <div class="auk-hr">
+          <hr/>
+        </div>
 
         <div class="auk-form-group">
           <WebComponents::AuLabel for="pages-amount">{{t "pages-amount"}}</WebComponents::AuLabel>

diff --git a/app/pods/cases/case/subcases/subcase/overview/template.hbs b/app/pods/cases/case/subcases/subcase/overview/template.hbs
@@ -1,7 +1,9 @@
 {{#if model}}
   <Subcases::SubcaseDescription @subcase={{this.subcase}}/>
   <div class="auk-u-mb-8">
-    <div class="vlc-hr"></div>
+    <div class="auk-hr">
+      <hr/>
+    </div>
   </div>
   {{#if this.currentSession.isEditor}}
    {{!-- TODO these classes do not exist and do nothing --}}

diff --git a/app/styles/app.scss b/app/styles/app.scss
@@ -57,7 +57,6 @@ $icon-font-location: '/fonts/'; // overrides the default location for flanders-i
 @import 'custom-components/vlc-document-list';
 @import 'custom-components/vlc-environment-pill';
 @import 'custom-components/vlc-dropdown-menu';
-@import 'custom-components/vlc-hr';
 @import 'custom-components/vlc-input-field-block';
 @import 'custom-components/vlc-list-section-header';
 @import 'custom-components/vlc-minister';

diff --git a/app/styles/au-kaleidos-css/_auk-hr.scss b/app/styles/au-kaleidos-css/_auk-hr.scss
@@ -4,7 +4,7 @@
 
 .auk-hr {
   margin: 2.4rem 0;
-  border-bottom: .1rem solid $au-gray-200;
+  border-bottom: .1rem solid $au-gray-300;
   hr {
     display: none;
   }

diff --git a/app/styles/custom-components/_vlc-agenda-items.scss b/app/styles/custom-components/_vlc-agenda-items.scss
@@ -187,7 +187,7 @@ $i: 0;
   border-bottom: .1rem solid $border-color;
 
   // Override HR spacing
-  .vlc-hr {
+  .auk-hr {
     margin: 1.5rem 0;
   }
 }

diff --git a/app/styles/custom-components/_vlc-hr.scss b/app/styles/custom-components/_vlc-hr.scss