Skip to content

feat: bind socket users to room updates only #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karanhudia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: bind socket users to room updates only #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/plugins/socket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,15 @@ declare module 'fastify' {
export const fastifySocketIo: FastifyPluginAsync = async (fastify) => {
await fastify.register(fastifyIO);

fastify.io.on('connection', (socket) => {
fastify.log.info('Socket connected!', socket.id);

fastify.io.on('connection', async (socket) => {
const uuid = socket.handshake.query.uuid as string;
if (uuid && !socket.rooms.has(uuid)) {
fastify.log.info(`Client(${socket.id}):: Joining Room - ${uuid}`);
await socket.join(uuid);
fastify.log.info(`Client(${socket.id}):: Joined Room - ${uuid}`);
}

// This method is deprecated, use createLottie from GraphQL instead
socket.on(
LottieSocketEvents.CreateJson,
async (
Expand Down Expand Up @@ -127,8 +133,8 @@ export const fastifySocketIo: FastifyPluginAsync = async (fastify) => {
},
);

// Broadcast this change to every client including the sender
fastify.io.emit(LottieSocketEvents.UpdateJson, message);
// Broadcast this change to every client in the room including the sender
fastify.io.to(message.uuid).emit(LottieSocketEvents.UpdateJson, message);

fastify.log.info(`Updating(${message.uuid}):: JSON lottie successfully updated`);

Expand Down