Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added usePagination CustomHook and TableWithPagination component #31

Conversation

ShwetKhatri2001
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR includes a reusable function/custom-hook to generate pagination for all types of data on different pages. Also, it includes an example of how to include it with data. The example shows how table data can be divided into pages and shown dynamically based on the page number. It is the implementation of this Figma Design ( Overview Page - iteration 7 frame ).

This PR is also using the DataTable component included in the last PR with some modifications to attach pagination for data in a table.

Which issue(s) this PR fixes:
It's a general component useful for different pages of the entire application.

Special notes for your reviewer:
@RainbowMango I'm attaching a preview and video link to show how the functionality of pagination included with the table works. We can use the pagination component similarly on any page for any usecase in future.

TablePagination

Video : https://www.loom.com/share/a1ab8e5047a74535a6cb601a2c99295d

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: ShwetKhatri2001 [email protected]

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 10, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2022
Copy link

@chinmaym07 chinmaym07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work done on this Pagination & Data component. @ShwetKhatri2001 💯

@RainbowMango
Copy link
Member

@chinmaym07 Do you think this PR is ready to move forward?

@RainbowMango
Copy link
Member

/close
Now we are currently refactoring it on master.

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closed this PR.

In response to this:

/close
Now we are currently refactoring it on master.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants