Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct translation string usage and JSX formatting in Popup confirm #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Jul 29, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The translation and string concatenation in the Popconfirm component to ensure proper rendering of the confirmation message and handling of translations.

Which issue(s) this PR fixes:
Fixes # N/A

Special notes for your reviewer: N/A

Does this PR introduce a user-facing change?:
N/A


Signed-off-by: axif [email protected]

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 29, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign warjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2024
@warjiang
Copy link
Contributor

warjiang commented Aug 6, 2024

Thanks for your translation, it's useful, but now we're developing a i18n cli tools for automatically translating, but now the cli in the status of WIP cc @chouchongYHMing, it will works in the mode of hybird including manual mode and auto mode, some of your translation is useful, but some are not we expected, like
image
we expected this kind of translation like ${i18nInstance.t('xxx', r.objectMeta.name)} and the map for xxx will be like 集群%1删除成功 for cn and Cluster%1delete successfully for en.
I think we can pend this pr, and renew it when the i18n-cli has any update

@warjiang
Copy link
Contributor

warjiang commented Sep 7, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants