fix(analysis): handle crash-first baselines and empty keep sets#469
Open
afurm wants to merge 1 commit into
Open
fix(analysis): handle crash-first baselines and empty keep sets#469afurm wants to merge 1 commit into
afurm wants to merge 1 commit into
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
barsharajyadav-boop
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
results.tsvhas no non-crash runs to analyzeKEEProws yet so the notebook does not fail on summary/plot generationWhy
The notebook previously used two different baseline definitions:
results.tsvThat means if the first logged experiment was a crash, the plot and summary could disagree about the baseline. The summary cell could also fail outright when there were no kept runs yet because it assumed
idxmin()was always valid.What changed
valid.emptybefore reading the baselinen/avalues instead of failing when there are no kept runs yetScope
This is analysis-only. No training code or experiment behavior changed.
Validation
analysis.ipynbis still valid JSON