Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new gallery image #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

new gallery image #22

wants to merge 4 commits into from

Conversation

mpadge
Copy link
Contributor

@mpadge mpadge commented Mar 3, 2016

hope you like it!

@karthik
Copy link
Owner

karthik commented Apr 11, 2016

Hi @mpadge,
Looking over the PR, I don't actually see the palette for BottleRocket2 that you added. The Travis test shows a clean badge because there is no test for BottleRocket2. Did you forget to add the palette itself?

@mpadge
Copy link
Contributor Author

mpadge commented Apr 11, 2016

BottleRocket2 is in your git version, as are two bottlerocket images. However, neither of the images is formatted like the others (and "./figure/bottlerocket-1.png" is much larger), so these images will still need to be updated (as will the man entry of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpadge @karthik