compute commit, mass calculation and generator fixes - #1074
Open
IzioDev wants to merge 8 commits into
Open
Conversation
IzioDev
commented
Jul 9, 2026
| Ok(settings) | ||
| } | ||
|
|
||
| #[allow(clippy::too_many_arguments)] |
IzioDev
changed the title
IzioDev
commented
Jul 10, 2026
| Fees::None => unreachable!("Fees::None can not occur for final transaction"), | ||
| }; | ||
|
|
||
| let max_tx_mass_for_additional_inputs = TRANSACTION_MASS_BOUNDARY_FOR_ADDITIONAL_INPUT_ACCUMULATION; |
Collaborator
Author
There was a problem hiding this comment.
remove and use const directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shifts transaction generation and WASM bindings toward the new compute_commit model, while updating mass calculations and covenant handling across consensus, wallet core, and WASM examples:
ComputeCommit.compute_commitand txversion, instead of plainsig_op_count.covenant_id.