Skip to content

Conversation

@wigwagwent
Copy link

In pull request #694 android support was removed from the build script. This adds it back in. From what I understand linux and android should be similar in the assembly file. I am not sure the correct way to test this. I can build the x86_64-linux-android target after this change.

@michaelsutton
Copy link
Contributor

In pull request #694 android support was removed from the build script. This adds it back in. From what I understand linux and android should be similar in the assembly file. I am not sure the correct way to test this. I can build the x86_64-linux-android target after this change.

so previous code was

    if target_arch == "x86_64" && target_os != "windows" && target_os != "macos" {
        cc::Build::new().flag("-c").file("src/keccakf1600_x86-64.s").compile("libkeccak.a");
    }

any other linux-related os that might have been dropped other than android?

cc @elichai

@elichai
Copy link
Member

elichai commented Nov 27, 2025

Interesting, yeah I probably didn't think of other platforms when I wrote it(in Kaspa-miner) 😅

All Linux based OSs should probably work,
Maybe some openbsd might work? Or it might be more similar to Macos than Linux,
The best way to check would be to run the tests with the asm while emulating those OSs, but I don't know off of hand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants