Add PQ signature scheme(Falcon512Padded) support to txscript #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biryukovmaxim
changed the title
Contributor
|
I understand this is a long-shot PR, but why not price a Falcon sig as N sigops? (say, 5 usual sigops). It seems redundant to add a new field |
Collaborator
Author
Makes sense. I initially was thinking that it would lead to u8 overflow at tx level |
…sage of `FALCON_FACTOR`
…anch and enable `getrandom_wasm_js` feature for `pqcrypto-falcon`
Collaborator
Author
|
corresponding pr rustpq/pqcrypto#94 |
# Conflicts: # consensus/src/processes/transaction_validator/tx_validation_in_utxo_context.rs # crypto/txscript/examples/kip-10.rs # crypto/txscript/src/lib.rs # crypto/txscript/src/opcodes/mod.rs # crypto/txscript/src/runtime_sig_op_counter.rs # crypto/txscript/src/standard/multisig.rs # wallet/pskt/src/pskt.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces full support for Falcon-512 (padded) signatures in the UTXO and script verification layers.
build fails in wasm. maybe we can replact the impl for wasm:https://github.com/partylikeits1983/falcon512-stm32/tree/main/falcon-wasm
wasm build will be fixed when i add support of wasm-unknown-unknown into pqcrypto repo. local fork works fine if i statically include wasm32-unknown-unknown-openbsd-libc