Wallet daemon #788

biryukovmaxim · 2025-12-19T11:42:57Z

Implement Rust wallet daemon inspired by kaspawalletd

Summary

This PR introduces a Rust-based gRPC wallet daemon as a replacement for the existing Go (kaspawalletd) implementation.

The primary goal is to provide a fully Rust-native wallet daemon that integrates cleanly with the existing Rust wallet framework and build system.

At this stage, the implementation is feature-complete enough for testing and review.

What’s included

New kaspa-wallet-daemon binary implemented in Rust
gRPC service definitions and server implementation (wallet/grpc/core, wallet/grpc/server)
Integration with kaspa-wallet-core
CI and release pipeline updates:
Build and package kaspa-wallet-daemon
Compatibility with existing Go-based gRPC wallet clients
Integration tests validated against an external Go test suite

Current limitations

Due to limitations in the current Rust wallet framework, the following are not yet supported:

ECDSA signing
Multisig
Fee bumping (RBF)

These are explicitly left out for now and will be addressed in follow-up work once the wallet framework supports them properly.

How to test

1. Run a Kaspa node (testnet)

cargo run --release --bin kaspad -- \
  --testnet \
  --utxoindex \
  --rpclisten-borsh=default \
  --rpclisten-json=default \
  --loglevel=kaspa_grpc_server=warn

2. Run the Rust wallet daemon

cargo run --package kaspa-wallet-daemon --bin kaspa-wallet-daemon -- \
--password "123" \
--name kaspa \
--network-id "testnet-10"

3. Integration tests (Go)

We validated the gRPC handlers using an external Go test suite:

https://github.com/childhoodisend/rusty-kaspa-wallet-test

…f-utils

… gamma-dev

…-utils

…erator-mass-calc

fix build

Impl broadcast method --------- Co-authored-by: Maxim <[email protected]>

* wallet deaemon: Implement broadcast_replacemant * Submit only the first transaction as replacement, the rest just as-is * Re-format

* feat: create unsigned transaction --------- Co-authored-by: 143672 <[email protected]>

# Conflicts: # clippy.toml

# Conflicts: # Cargo.lock # wallet/core/src/api/message.rs # wallet/pskt/Cargo.toml

* feat: sign and sign_transactions improvements * fix: review

IzioDev · 2025-12-19T15:15:24Z

.github/workflows/ci.yaml

          source musl-toolchain/build.sh
          # Build for musl
-          cargo --verbose build --bin kaspad --bin rothschild --bin kaspa-wallet --release --target x86_64-unknown-linux-musl
+          cargo --verbose build --bin kaspad --bin rothschild --bin kaspa-wallet-daemon --release --target x86_64-unknown-linux-musl


If the introduced deamon needs to also be built, it should be a new binary, probably not replacing the kaspa-wallet (cli)

wallet/native binary just reruns kaspa-cli.. there's no point to have such wrapper

rusty-kaspa/wallet/native/src/main.rs

Line 5 in 2ccc9e4

let result = kaspa_cli(TerminalOptions::new().with_prompt("$ "), None).await;

How should Kaspa users (ex: me as a user) run the CLI without the codebase providing an entry point? (and potentially a built binary: cli.exe)

I guess it would require me to compile locally after having re-added such an entry-point file, correct?

kaspa-cli is a binary. You can either run or build it. I don't see any difference

Ok, got it now, thanks.

So I think we should introduce kaspa-cli now, so that its build is being tested in ci, and its builds still are published as release assets, what do you think?

Yes, that makes sense. I thought it was already there

IzioDev · 2025-12-19T15:16:10Z

.github/workflows/deploy.yaml

General comment: kaspa-wallet-daemon should be consider an addition, not a replacement to the already existing kaspa-wallet (cli)

rusty-kaspa/wallet/native/src/main.rs

Line 5 in 2ccc9e4

let result = kaspa_cli(TerminalOptions::new().with_prompt("$ "), None).await;

the crate was deleteed by @KaffinPX since its existence doesnt make sense

IzioDev · 2025-12-19T15:17:33Z

wallet/core/src/account/mod.rs

+        // update address manager with the last used index
+        if update_address_indexes {
+            receive_address_manager.set_index(last_receive_address_index)?;
+            change_address_manager.set_index(last_change_address_index)?;
+
+            let metadata = self.metadata()?.expect("derivation accounts must provide metadata");
+            let store = self.wallet().store().as_account_store()?;
+            store.update_metadata(vec![metadata]).await?;
+            self.clone().scan(None, None).await?;
+            self.wallet().notify(Events::AccountUpdate { account_descriptor: self.descriptor()? }).await?;
+        }
+


Seems to be a conflict handling artifact, this block is duplicated with the one previously in the code (line 777)

IzioDev · 2025-12-20T11:12:14Z

wallet/daemon/src/args.rs

+    Command::new("kaspawalletd")
+        .about(format!("{} (kaspawalletd) v{}", env!("CARGO_PKG_DESCRIPTION"), version()))
+        .version(env!("CARGO_PKG_VERSION"))
+        .arg(Arg::new("password").long("password").short('p').value_name("password").help("Path of password file"))


add .required(true), otherwise the program panic if no password provided (non informative output)

replace "Path of password file" with "Password" or "Wallet secret", in implementation it's not used to provide a password file

IzioDev · 2025-12-20T11:13:07Z

wallet/daemon/src/args.rs

+                .long("name")
+                .short('n')
+                .value_name("name")
+                .value_parser(clap::value_parser!(String))


Is value parser on String useful here?
According to clap documentation, String is the default value parser

there are other cases where the same pattern is used. I don't see any issues with explicitly passed parser

IzioDev · 2025-12-20T11:18:05Z

wallet/daemon/src/args.rs

+            Arg::new("name")
+                .long("name")
+                .short('n')
+                .value_name("name")


value_name is useful to display a more informative help panel (it has no other use).

example before:

example after:

default value is arg name, so no need to re-define without a different value

IzioDev · 2025-12-20T11:23:13Z

wallet/daemon/src/main.rs

+    kaspa_core::log::init_logger(None, "");
+    let args = Args::parse();
+
+    let wallet = Arc::new(Wallet::try_new(Wallet::local_store()?, Some(Resolver::default()), None)?);


Note: Golang daemon allowed user to select a specific wallet file (by explicit path)

coderofstuff · 2025-12-23T07:19:39Z

@biryukovmaxim Please add a description to this PR

…let for backward compatibility

…odule

biryukovmaxim · 2026-01-02T17:04:45Z

@biryukovmaxim Please add a description to this PR

Done

aspect and others added 30 commits September 2, 2024 16:02

pending tx (WIP)

d004d89

Merge branch 'dev' of https://github.com/kaspanet/rusty-kaspa into rb…

8ccf8a4

…f-utils

wip

db21255

WIP fee_rate

8d06a34

WIP

0ccad51

Merge branch 'dev' of https://github.com/kaspanet/rusty-kaspa into rb…

db1ec4f

…f-utils

fee rate propagation

bc254da

propagate fee_rate in generator tests

e8cbe86

WIP

c9e9247

change fee_rate combining to use max()

0fff1ef

update max() handling

be33081

Merge branch 'dev' of https://github.com/kaspanet/rusty-kaspa into rb…

bf434fd

…f-utils

Generator summary aggregate_mass

4cf3d52

Merge branch 'dev' of https://github.com/kaspanet/rusty-kaspa into rb…

9314168

…f-utils

generator summary number_of_stages

b910457

Merge branch 'master' of https://github.com/kaspanet/rusty-kaspa into…

d82b2c2

… gamma-dev

WIP

458354b

Merge branch 'kaspanet:master' into rbf-utils

bc583a5

Merge branch 'gamma-dev' of github.com:aspectron/rusty-kaspa into rbf…

29e32c9

…-utils

calculateStorageMass

4a1e5ef

Merge branch 'gamma-dev' of github.com:aspectron/rusty-kaspa into gen…

5993abb

…erator-mass-calc

cleanup

c8d829c

cleanup tests

aaf66d4

fix wasm imports

350bd39

Merge branch 'master' of github.com:aspectron/rusty-kaspa into gamma-dev

8d47393

update wrpc/client/Cargo.toml to include Resolvers.toml config file

53c4bbe

Merge branch 'master' into gamma-dev

65a6967

accounts_import api impl (#107)

8147bdd

add missing setNetworkId to wasm Wallet()

158d4be

rust 1.82 updates

79cebc0

biryukovmaxim and others added 17 commits May 18, 2025 15:51

Merge pull request #167 from biryukovmaxim/fix-build

a2b52af

fix build

Merge branch 'sigma' into wallet-daemon

516d90b

Broadcast (#166)

94e4a04

Impl broadcast method --------- Co-authored-by: Maxim <[email protected]>

Merge branch 'master' into sigma

80a72bd

Merge branch 'kaspanet:master' into sigma

ad7e91a

fix handling of empty signature

08a09b6

Wallet deamon: Implement broadcast_replacemant (#169)

0c3dc53

* wallet deaemon: Implement broadcast_replacemant * Submit only the first transaction as replacement, the rest just as-is * Re-format

Create unsigned transaction (#168)

8d3e08a

* feat: create unsigned transaction --------- Co-authored-by: 143672 <[email protected]>

Merge branch 'master' of github.com:aspectron/rusty-kaspa

5c01bd2

Merge branch 'sigma' into wallet-daemon

278f05c

# Conflicts: # clippy.toml

Merge branch 'master' into wallet-daemon

caa00fa

# Conflicts: # Cargo.lock # wallet/core/src/api/message.rs # wallet/pskt/Cargo.toml

Merge branch 'kaspanet:master' into master

b251c95

Merge remote-tracking branch 'aspectron/master' into wallet-daemon

03e0400

wallet daemon: sign / sign_transactions improvements (#173)

fc21b72

* feat: sign and sign_transactions improvements * fix: review

Merge branch 'master' into wallet-daemon

e86920c

fix: receive_addresses indexes (#176)

efb835a

Merge branch 'master' into wallet-daemon

0fc02d7

biryukovmaxim marked this pull request as ready for review December 19, 2025 11:49

biryukovmaxim requested review from IzioDev and aspect and removed request for IzioDev December 19, 2025 11:49

IzioDev reviewed Dec 19, 2025

View reviewed changes

IzioDev reviewed Dec 20, 2025

View reviewed changes

biryukovmaxim added 4 commits January 2, 2026 20:44

Merge branch 'refs/heads/master' into wallet-daemon

a6b0b9b

Add kaspa-cli to build and deployment workflows, name it as kaspa-wal…

46cdc92

…let for backward compatibility

Remove redundant address index and metadata update logic in account m…

fd79e1f

…odule

Make --password argument mandatory in kaspawalletd

785f772

Wallet daemon #788

Are you sure you want to change the base?

Wallet daemon #788

Uh oh!

Conversation

biryukovmaxim commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implement Rust wallet daemon inspired by kaspawalletd

Summary

What’s included

Current limitations

How to test

1. Run a Kaspa node (testnet)

2. Run the Rust wallet daemon

3. Integration tests (Go)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderofstuff commented Dec 23, 2025

Uh oh!

biryukovmaxim commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

biryukovmaxim commented Dec 19, 2025 •

edited

Loading